• SorteKanin@feddit.dk
    link
    fedilink
    arrow-up
    11
    ·
    11 hours ago

    Duration::from_mins and Duration::from_hours seems nice. Otherwise kind of a boring release if you ask me.

      • SorteKanin@feddit.dk
        link
        fedilink
        arrow-up
        5
        ·
        edit-2
        2 hours ago

        Duration::from_days was proposed but consensus was not reached as “day” is somewhat complicated as that sometimes can be 23 hours or 25 hours due to daylight savings or 23:59 due to leap seconds shenanigans.

        • anton@lemmy.blahaj.zone
          link
          fedilink
          arrow-up
          1
          ·
          44 minutes ago

          Leap seconds are already a problem for minutes and hours, which is probably why they weren’t added until now.

      • SorteKanin@feddit.dk
        link
        fedilink
        arrow-up
        4
        ·
        edit-2
        11 hours ago

        I know, but they used to be more exciting I feel like - but I guess it’s only natural that development speed goes down as more and more low-hanging fruit has already been picked. What remains of the non-boring stuff is probably quite complicated and difficult to stabilize.

  • NGram@piefed.ca
    link
    fedilink
    English
    arrow-up
    6
    ·
    13 hours ago

    The strict_* set of integer function look interesting though I’m unlikely to use something that panics by design. I’m sure that’s useful in programs that panic to indicate problems. Do those exist? I always treat panics as a design failure.

    Duration::from_mins() is useful for me since I’ve been doing Duration::from_secs(minutes * 60) for some things in my projects, which bugged me a bit.

    • FizzyOrange@programming.dev
      link
      fedilink
      arrow-up
      2
      ·
      11 hours ago

      The non-strict versions also panic by default, but only in debug mode. So if you were willing to use abs() you should be willing to use strict_abs().

      Arguably a bit of a mistake to have the “obvious” function names be surprisingly unsafe, but I guess it’s too late to fix that.