Please excuse - and do not hesitate to point out - any violation against etiquette that I might be committing here… I am new here.
I started to learn C a few months ago as a hobby as part of a bigger project, namely to learn about computers in general. I have had so much fun reading Code - The Hidden Language of Computer Hardware and Software by Charles Petzold. But that’s another story…
I was about to buy a few new SSDs and needed to do some budgeting. Instead of using my phone’s calculator, I decided to try to write a calculating program in C, because I hadn’t touched programming for some weeks or months because life and I wanted to see if my knowledge had matured some.
The goal was to have it do the four standard arithmetics and also save the last result in a variable, which I just called “memory” for lack of bette phrasing on my part. Maybe next week I’ll figure out how to make it possible to use the value saved in memory instead of having to type a number.
I welcome any constructive criticism on how and why this code is up to code or not(sorry…), if it can be improved and how or even if it’s just garbage and why that is. I am just proud that it worked without gcc throwing any errors.
#include <stdio.h>
int main(void) {
int num1 = 0;
int num2 = 0;
int choice = 0;
int memory = 0;
printf("Welcome to the Calculator of the century!\n\n");
while (1) {
printf("What would you like to do?\n\n");
printf("(1) Add two numbers\n(2) Subtract two numbers\n(3) Multiply two numbers\n(4) Divide two numbers\n(5) Show memory\n(6) Exit\n\n");
printf("Enter 1, 2, 3, 4, 5 or 6: ");
scanf("%d", &choice);
if (choice >= 6 || choice < 1) break;
if (choice == 5) {
printf("\n%d in memory.\n\n", memory);
} else if (choice < 5 || choice > 0) {
printf("\nEnter the first number: ");
scanf("%d", &num1);
printf("Enter the second number: ");
scanf("%d", &num2);
}
if (choice == 1) {
printf("\nThe sum of %d and %d is %d\n\n", num1, num2, num1 + num2);
memory = num1 + num2;
} else if (choice == 2) {
printf("\nThe difference of %d and %d is %d\n\n", num1, num2, num1 - num2);
memory = num1 - num2;
} else if (choice == 3) {
printf("\nThe product of %d and %d is %d\n\n", num1, num2, num1 * num2);
memory = num1 * num2;
} else if (choice == 4) {
printf("\nThe quotient of %d and %d is %d\n\n", num1, num2, num1 / num2);
memory = num1 / num2;
}
}
printf("\nWe hope to see you soon again!\n");
return 0;
}


One thing you can do that I find comes up pretty often in C is start using switch statements to avoid code duplication. Because your operators all take 2 numbers, you’ve separated out the input handling into its own block; that alone is a really good insight.
You can take it another step further by making your print statement also, mostly, one block of code, with the only difference being the operation being preformed. By printing “The” followed by using an if-else block — or, again, preferably a switch statement — to both print the operation text, and compute
memory, you can print the remainder of the line the same way for every operation.It may seem nitpicky for such a simple program; but the use case of C is for programs which require tight execution and often contain complex, low-level logic. Reducing complexity whenever possible helps make C more readable, as well as signal when the complexity is necessary.